This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Fix panic in router disconnect when fingerprint is nil. Fixes #1548 #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
reviewed
Aug 16, 2023
| @@ -191,7 +192,7 @@ func (strategy *InstantStrategy) RouterDisconnected(router *network.Router) { | |||
| log := pfxlog.Logger().WithField("sync_strategy", strategy.Type()). | |||
There was a problem hiding this comment.
This is already fixed. Not sure why it doesn't show up that way.
There was a problem hiding this comment.
Weird. I didn't add this.
There was a problem hiding this comment.
Also this isn't what I named the PR.
plorenz
approved these changes
Aug 16, 2023
|
I'm going to abandon this PR. I'm not sure what is going on here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.