Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt mwoffliner configuration for 1.14 #992

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Adapt mwoffliner configuration for 1.14 #992

merged 1 commit into from
Jul 17, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jul 1, 2024

Rationale

Fix #990

NOTA: it looks like mwRestApiPath is not exposed for now, or I missed it in the code.

This is not ready yet for rollout (1.14 is not yet out), and will need an immediate reconfiguration of the DB to change parameter name from mwApiPath to mwActionApiPath see kiwix/operations#214

@benoit74 benoit74 self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (a040ffe) to head (a33586e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   88.13%   88.14%           
=======================================
  Files          94       94           
  Lines        5309     5312    +3     
=======================================
+ Hits         4679     4682    +3     
  Misses        630      630           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor

NOTA: it looks like mwRestApiPath is not exposed for now, or I missed it in the code.

What do you mean you with that? You mean in the code of MWoffliner? I would like to merge this PR now, so we can move forward?

@audiodude
Copy link
Member

NOTA: it looks like mwRestApiPath is not exposed for now, or I missed it in the code.

What do you mean you with that? You mean in the code of MWoffliner? I would like to merge this PR now, so we can move forward?

@benoit74 do you mean https://github.com/openzim/mwoffliner/blob/main/src/parameterList.ts#L21 ?

@benoit74
Copy link
Collaborator Author

What do you mean you with that? You mean in the code of MWoffliner?

I mean that mwRestApiPath was already a parameter in 1.13 but has not yet been made available on the Zimfarm recipes.

I would like to merge this PR now, so we can move forward?

We can do it whenever you want, I understood the plan was first to purge the cache and release 1.14, but I don't really mind in fact since all recipes all paused anyway.

Can you please confirm the list of parameters I've added in this PR is correct and that there is no typo?

@benoit74 benoit74 marked this pull request as ready for review July 17, 2024 05:17
@benoit74
Copy link
Collaborator Author

Let's merge this, it looks like nobody would like to confirm the list of parameters is OK.

@benoit74 benoit74 merged commit e1eb555 into main Jul 17, 2024
5 checks passed
@benoit74 benoit74 deleted the mwoffliner_1_14 branch July 17, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to MWoffliner 1.14
3 participants