Many fixes for reliability of the scraper #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blank URL to not load external assets + display warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 43.85% 43.14% -0.72%
==========================================
Files 15 15
Lines 969 978 +9
Branches 133 133
==========================================
- Hits 425 422 -3
- Misses 529 545 +16
+ Partials 15 11 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
For the record, I abused the |
…ff only when needed
benoit74
force-pushed
the
reliability
branch
from
1d4b766
to
32d8faf
Compare
rgaudin
approved these changes
Nov 22, 2024
| if len(private_pages) == len(selected_pages): | ||
| # we should never get here since we already check fail early if root | ||
| # page is private, but we are better safe than sorry | ||
| raise Exception("All pages have been ignored, not creating an empty ZIM") |
| f"Exception while processing asset for {asset_url.value}: " | ||
| f"{exc}" | ||
| ) | ||
| raise Exception( # noqa: B904 |
There was a problem hiding this comment.
We should use more qualified exceptions such as OSError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #74
Fix #76
Fix #77 (and glossary had the same problem)
Workaround for #71 (real solution postponed to "later") and many other likely situations where we encounter an "unknown" src/href/srcset (inline JS and CSS, ...)
Changes: see list of commits
Some remarks:
--html-issues-warn-onlybecause now we do not have such issues anymore, we are always just logging a warning because these issues are here to stay and we do not want to fail the scrape just for few isolated issues (they are really isolated from test scrape which ran last days)