feat: align media type with sd-jwt-vc draft 06 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charsleysa
requested review from
lukasjhan,
zustkeeper,
berendsliedrecht and
cre8
as code owners
Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
charsleysa
force-pushed
the
feat-sd-jwt-vc-06
branch
from
c72029d
to
23d2f67
Compare
|
@charsleysa thanks for the PR! @lukasjhan I would be fine with this change without marking it as a breaking change. The sd-jwt vc spec is still in draft |
|
@cre8 I'm also fine with this change :). Let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft 06 changes the media type from
vc+sd-jwttodc+sd-jwt.https://author-tools.ietf.org/iddiff?url1=draft-ietf-oauth-sd-jwt-vc-05&url2=draft-ietf-oauth-sd-jwt-vc-06&difftype=--html
oauth-wg/oauth-sd-jwt-vc#268