Fix tofu output printing debug information

[VladMasarik]

After looking around a bit I found the wrapper part where the debug is printed out. I also compared the Terraform setup and OpenTofu setup code, and found out how they actually fixed it. I tested the fix myself and saw that the debug was removed.

Before:

After:

Closes #6 #18
I am not sure what to do about #28

[ghost]

@VladMasarik thank you for your contribution. However, because we are very careful about not copying Terraform code, I have to ask: is this PR a copy of what Terraform did or is this your own code?

[VladMasarik]

Hi @janosdebugs , sure no problem, but I am not sure what to say. At first I found the part where it was printing out the debug code myself, and fixed it myself.

I then wondered when this ‘bug’ was added to Tofu since I never encountered it in Terraform, so I checked the commits. I saw that this was added in the initial commit, so I checked the diff with Terraform thinking the bug was added in the initial commit. However, I saw that they also deleted the debug code 6 months ago so I thought the author just missed it. I then found a solution similar to mine, but they also added a workaround for the [command] issue, which I didn't notice at first.

So I wrote it myself, then noticed that I also needed to add the [command] fix as well, and added a solution similar to theirs. I am scared of wording here, but I did add the silent: true line myself. I now see that I even made a typo in there, but then I used copy paste for the last 3 lines since my fix would have been literally the same, and it also included a useful comment.

So I have no clue. There is only one way to actually delete the debug output, replace it with regular stdout, and add the workaround. Their PR actually says that they were trying to fix a completely different issue A at the start, but later also noticed issue B with the debug output. I, on the other hand, came in trying to fix issue B at first, and then realized that I need to also fix issue A. The commits / PR are not identical because they have added many more changes, and the index.js is build by me.

What should I do if this is a problem? Sorry to say but this problem has been present for over 6 months now, nobody is picking it up, and for me was the most frustrating hurdle to overcome for migration to tofu. The solution is to delete debug output, you can do that literally only one way, and then add the silent flag so that the [command] is not printed out. I am happy to close this PR and rewrite it physically myself, but it will still have the deleted debug, and workaround for the [command] issue. I could also split it up into two PRs, to first delete the debug output, and then another PR for disabling the [command].

Sorry for so much text, but I am worried I have / might put this project into jeopardy for deleting 4 lines and adding a print statement 😄 but I understand your situation, so do let me know your thoughts 👍

[ghost]

Hey @VladMasarik thank you for your extensive answer and understanding. I'll consult with my fellow core engineers and get back to you next week. At any rate, we'll find a solution to sort this problem out.

[ghost]

Hey @VladMasarik thank you for your patience. I discussed this with the core team and since the setup-terraform repo is also MPL-licensed, there is no reason to hold back this PR :)

[timkrins]

It would be great to have this in a release! For now I've pinned my version to this commit.

- uses: opentofu/setup-opentofu@12f4debbf681675350b6cd1f0ff8ecfbda62027b

[ghost]

@timkrins done: https://github.com/opentofu/setup-opentofu/releases/tag/v1.0.4