Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Improve concurrency logic in oauth controller code #389

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(auth): Improve concurrency logic in oauth controller code #389

wants to merge 4 commits into from

Commits on Nov 18, 2024

  1. fix(auth): rewrite auth logic 

    - move more logic behind a promise to let the promise act as an initializer
- not perfect probably? I still don't really grok how to use promises to think about concurrency in js
    @dmihalcik-virtru
    dmihalcik-virtru committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    12c0031 View commit details
    Browse the repository at this point in the history

  2. Update oidc.ts

    @dmihalcik-virtru
    dmihalcik-virtru committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    710e431 View commit details
    Browse the repository at this point in the history

  3. Update auth.test.ts

    @dmihalcik-virtru
    dmihalcik-virtru committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    13c7a74 View commit details
    Browse the repository at this point in the history

  4. ugh just use an explicit mutex

    @dmihalcik-virtru
    dmihalcik-virtru committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    50aa168 View commit details
    Browse the repository at this point in the history