feat(sdk): Allow custom KAO array templates #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
force-pushed
the
feature/encryption-info-versioning
branch
from
d9df338
to
b3ed7b2
Compare
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
pflynn-virtru
previously approved these changes
Jul 15, 2024
dmihalcik-virtru
force-pushed
the
feature/encryption-info-versioning
branch
from
ec2b51c
to
d7d484c
Compare
dmihalcik-virtru
changed the title
dmihalcik-virtru
force-pushed
the
feature/encryption-info-versioning
branch
from
d7d484c
to
938d2ea
Compare
pflynn-virtru
previously approved these changes
Jul 16, 2024
dmihalcik-virtru
force-pushed
the
feature/encryption-info-versioning
branch
2 times, most recently
from
08625d6
to
445e20c
Compare
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Small refactor to consolidate KAS methods
- Adds the ability to share and split DEKs - Reconstructs keys using share ids - Does NOT support TDFs that were created with id-less splits. While the old code did support reading them, it did not support creating them
Signed-off-by: David Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
force-pushed
the
feature/encryption-info-versioning
branch
from
dac8253
to
6180784
Compare
|
elizabethhealy
approved these changes
Aug 21, 2024
dmihalcik-virtru
added a commit
that referenced
this pull request
Aug 22, 2024
- Adds the ability to share and split DEKs - Reconstructs keys using share ids This will allow opening of files with multi-kas splits. Step 1 of #314 While I'm here I also: 1. Lets platform-xtest job run in parallel with other e2e tests 2. Updates config for platform-roundtrip job, since the `provision fixture keycloak` needs a new config file 3. Adds a new phony make target to simplify development, you can now `make cli` to get the cli without having to guess the version number 4. Adds a `prettier ignore` directive so `make format` no longer formats the generated protocol buffer code 5. Updates the fetching of KAS public keys to happen during encrypt, not during client creation. This makes more sense now that we don't know at client start time which kases will actually be involved in the encrypt step --- Co-authored-by: Patrick Bacon-Blaber <pbacon-blaber@virtru.com> Signed-off-by: David Mihalcik <dmihalcik@virtru.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow opening of files with multi-kas splits.
Step 1 of #314
While I'm here I also:
provision fixture keycloakneeds a new config filemake clito get the cli without having to guess the version numberprettier ignoredirective somake formatno longer formats the generated protocol buffer code