Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provisioning): Keycloak provisioning from custom config #573

Merged
merged 26 commits into from
Apr 25, 2024
Merged

feat(provisioning): Keycloak provisioning from custom config #573

merged 26 commits into from
Apr 25, 2024

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Apr 12, 2024 •
edited
Loading

Custom keycloak provisioning

Allows for custom keycloak setup including custom users, groups, clients, attributes etc
Follow the example yaml for setup, uses gocloak client/user/group json representations

@jrschumacher
Copy link
Member

@elizabethhealy this is awesome work! Would this deprecate the other key cloak provisioner? If so, could we validate that it can do the same thing and remove the defunct code with this PR?

@elizabethhealy
Copy link
Member Author

@elizabethhealy this is awesome work! Would this deprecate the other key cloak provisioner? If so, could we validate that it can do the same thing and remove the defunct code with this PR?

@jrschumacher not fully, this doesn't support the token exchange setup yet, i can work on adding that

@strantalis
Copy link
Member

@elizabethhealy Can you sync with @mkleene. I think he has some keycloak command changes in pr #546 as well.

@elizabethhealy elizabethhealy marked this pull request as ready for review April 22, 2024 16:26
@elizabethhealy elizabethhealy requested review from a team as code owners April 22, 2024 16:26
@elizabethhealy
Copy link
Member Author

elizabethhealy commented Apr 22, 2024 •
edited
Loading

@jrschumacher i cleaned this up a little to remove some of the duplication with the other keycloak provisioning, the other kc provision command still exists but they call the same functions

@elizabethhealy elizabethhealy requested review from a team as code owners April 23, 2024 17:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@elizabethhealy elizabethhealy changed the title feat(provisioning): Keycloak provisiong from custom config and policy data bootstrapping from config feat(provisioning): Keycloak provisioning from custom config Apr 25, 2024
@elizabethhealy elizabethhealy added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit f9e9d72 Apr 25, 2024
16 checks passed
@elizabethhealy elizabethhealy deleted the keycloak-from-config-file branch April 25, 2024 20:00
This was referenced Apr 25, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
@opentdf-automation @jakedoublev
chore(main): release lib/fixtures 0.2.0 (#638)
6fe7d46 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](lib/fixtures/v0.1.0...lib/fixtures/v0.2.0)
(2024-04-26)


### Features

* allow --insecure in provision keycloak cmd
([#629](#629))
([a672325](a672325))
* **provisioning:** Keycloak provisioning from custom config
([#573](#573))
([f9e9d72](f9e9d72))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
@opentdf-automation @jakedoublev
chore(main): release service 0.2.0 (#641)
655d527 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](service/v0.1.0...service/v0.2.0)
(2024-04-26)


### Features

* **policy:** move key access server registry under policy
([#655](#655))
([7b63394](7b63394))
* **provisioning:** Keycloak provisioning from custom config
([#573](#573))
([f9e9d72](f9e9d72))
* **sdk:** make enforcement of DPoP optional
([#617](#617))
([028064c](028064c))


### Bug Fixes

* **core:** remove unused db argument
([#653](#653))
([cfbd168](cfbd168))
* **db:** invalid uuid error message
([#633](#633))
([c8f61aa](c8f61aa))
* **sdk:** this (`enforceDPoP`) flag needs to be flipped
([#649](#649))
([dd65db1](dd65db1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: jakedoublev <jake.vanvorhis@virtru.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation @jakedoublev
chore(main): release lib/fixtures 0.2.0 (#638)
c70838c 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](opentdf/platform@lib/fixtures/v0.1.0...lib/fixtures/v0.2.0)
(2024-04-26)


### Features

* allow --insecure in provision keycloak cmd
([#629](opentdf/platform#629))
([a672325](opentdf/platform@a672325))
* **provisioning:** Keycloak provisioning from custom config
([#573](opentdf/platform#573))
([f9e9d72](opentdf/platform@f9e9d72))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation @jakedoublev
chore(main): release service 0.2.0 (#641)
d47be08 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](opentdf/platform@service/v0.1.0...service/v0.2.0)
(2024-04-26)


### Features

* **policy:** move key access server registry under policy
([#655](opentdf/platform#655))
([7b63394](opentdf/platform@7b63394))
* **provisioning:** Keycloak provisioning from custom config
([#573](opentdf/platform#573))
([f9e9d72](opentdf/platform@f9e9d72))
* **sdk:** make enforcement of DPoP optional
([#617](opentdf/platform#617))
([028064c](opentdf/platform@028064c))


### Bug Fixes

* **core:** remove unused db argument
([#653](opentdf/platform#653))
([cfbd168](opentdf/platform@cfbd168))
* **db:** invalid uuid error message
([#633](opentdf/platform#633))
([c8f61aa](opentdf/platform@c8f61aa))
* **sdk:** this (`enforceDPoP`) flag needs to be flipped
([#649](opentdf/platform#649))
([dd65db1](opentdf/platform@dd65db1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: jakedoublev <jake.vanvorhis@virtru.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation @jakedoublev
chore(main): release lib/fixtures 0.2.0 (#638)
89c6c21 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](opentdf/platform@lib/fixtures/v0.1.0...lib/fixtures/v0.2.0)
(2024-04-26)


### Features

* allow --insecure in provision keycloak cmd
([#629](opentdf/platform#629))
([a672325](opentdf/platform@a672325))
* **provisioning:** Keycloak provisioning from custom config
([#573](opentdf/platform#573))
([f9e9d72](opentdf/platform@f9e9d72))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation @jakedoublev
chore(main): release service 0.2.0 (#641)
874b7ad 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](opentdf/platform@service/v0.1.0...service/v0.2.0)
(2024-04-26)


### Features

* **policy:** move key access server registry under policy
([#655](opentdf/platform#655))
([7b63394](opentdf/platform@7b63394))
* **provisioning:** Keycloak provisioning from custom config
([#573](opentdf/platform#573))
([f9e9d72](opentdf/platform@f9e9d72))
* **sdk:** make enforcement of DPoP optional
([#617](opentdf/platform#617))
([028064c](opentdf/platform@028064c))


### Bug Fixes

* **core:** remove unused db argument
([#653](opentdf/platform#653))
([cfbd168](opentdf/platform@cfbd168))
* **db:** invalid uuid error message
([#633](opentdf/platform#633))
([c8f61aa](opentdf/platform@c8f61aa))
* **sdk:** this (`enforceDPoP`) flag needs to be flipped
([#649](opentdf/platform#649))
([dd65db1](opentdf/platform@dd65db1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: jakedoublev <jake.vanvorhis@virtru.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elizabethhealy @jrschumacher @strantalis @mkleene