fix: grpc-gateway connection with tls enabled #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
approved these changes
Nov 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.28](service/v0.4.27...service/v0.4.28) (2024-11-15) ### Features * **sdk:** add collections for nanotdf ([#1695](#1695)) ([6497bf3](6497bf3)) ### Bug Fixes * **core:** Autobump service ([#1767](#1767)) ([949087e](949087e)) * **core:** Autobump service ([#1771](#1771)) ([7a2e709](7a2e709)) * **core:** Updates dpop check for connect ([#1760](#1760)) ([6d7f24a](6d7f24a)) * grpc-gateway connection with tls enabled ([#1758](#1758)) ([3120350](3120350)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes grpc-gateway from endpoint to support tls. This was a miss on the initial pr #1733 because we don't have any tests where we enable tls. So this pull request updates the integration tests to run with tls enabled as well.
Checklist
Testing Instructions