Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Introduce ERS mode, ability to connect to remote ERS #1735

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Nov 12, 2024

Proposed Changes

  • ERS mode to run an ERS on its own
  • Ability to connect to a remote ers:
    • sdk config updated to include connection params: endpoint, plaintext, insecure

End result for configs: if running in core more you need to provide a sdk_config since an ERS connection is needed for authorization, ability to run in entityresolution mode, ability to configure core and ers connections with sdk_config (plaintext, insecure, endnpoint)

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@elizabethhealy elizabethhealy changed the title feat(ers): Introduce ERS mode, ability to connect to remote ERS feat(core): Introduce ERS mode, ability to connect to remote ERS Nov 12, 2024
@elizabethhealy
Copy link
Member Author

elizabethhealy commented Nov 25, 2024

xtest is failing because it calls a reusable workflow in this repo on the main branch. when running against an xtest branch that calls the reusable workflow from this branch (which has been updated) it passes https://github.com/opentdf/platform/actions/runs/12015619289/job/33494067371
so xtest will pass again officially when this is merged to main

@elizabethhealy elizabethhealy marked this pull request as ready for review November 25, 2024 17:47
@elizabethhealy elizabethhealy requested review from a team as code owners November 25, 2024 17:47
pflynn-virtru
pflynn-virtru previously approved these changes Nov 25, 2024
docs/configuration.md Outdated Show resolved Hide resolved
opentdf-ers-mode.yaml Show resolved Hide resolved
service/internal/config/config.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants