feat(kas): collect metrics #1702
Open
+749
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pflynn-virtru
previously approved these changes
Nov 8, 2024
dmihalcik-virtru
requested changes
Nov 14, 2024
dmihalcik-virtru
approved these changes
Nov 19, 2024
dmihalcik-virtru
previously approved these changes
Nov 19, 2024
examples/cmd/examples.go
Outdated
| @@ -31,7 +31,7 @@ func init() { | |||
|
|
|||
| func newSDK() (*sdk.SDK, error) { | |||
| resolver.SetDefaultScheme("passthrough") | |||
| opts := []sdk.Option{sdk.WithStoreCollectionHeaders()} | |||
There was a problem hiding this comment.
Is this causing failures in integration test?
examples/cmd/examples.go
Outdated
| @@ -31,7 +31,7 @@ func init() { | |||
|
|
|||
| func newSDK() (*sdk.SDK, error) { | |||
| resolver.SetDefaultScheme("passthrough") | |||
| opts := []sdk.Option{sdk.WithStoreCollectionHeaders()} | |||
| opts := []sdk.Option{sdk.WithStoreCollectionHeaders(), sdk.WithInsecurePlaintextConn()} | |||
There was a problem hiding this comment.
you probably want to drop sdk.WithStoreCollectionHeaders().
There is no way to determine if a nanoTDF is part of a collection or not, with this option on, it will always assume its part of a collection.
Since you are decrypting the same nanoTDF, it will store the key with the header and future decrypts will skip the rewrap call.
It's probably best that you remove this option for benchmarking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.