-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add connection to optional remote ers #1601
base: separate-keycloak-ers-implementation
Are you sure you want to change the base?
feat(core): Add connection to optional remote ers #1601
Conversation
This comment has been minimized.
This comment has been minimized.
func getNewGRPCConn(url string) (*grpc.ClientConn, error) { | ||
defaultOptions := []grpc.DialOption{ | ||
grpc.WithTransportCredentials(insecure.NewCredentials()), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: support dial options in the yaml config
This comment has been minimized.
This comment has been minimized.
1 similar comment
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
modeoptions: | ||
remoteERSUrl: http://localhost:8181 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts if we moved this configuration underneath SDKConfig
. Trying to think how we could layer in other options for our internal products as well.
platform/service/internal/config/config.go
Lines 45 to 58 in c36624c
type SDKConfig struct { | |
// Endpoint is the URL of the Core Platform endpoint. | |
Endpoint string `mapstructure:"endpoint" json:"endpoint"` | |
// Plaintext specifies whether the SDK should use plaintext communication. | |
Plaintext bool `mapstructure:"plaintext" json:"plaintext" default:"false" validate:"boolean"` | |
// ClientID is the client ID used for client credentials grant. | |
// It is required together with ClientSecret. | |
ClientID string `mapstructure:"client_id" json:"client_id" validate:"required_with=ClientSecret"` | |
// ClientSecret is the client secret used for client credentials grant. | |
// It is required together with ClientID. | |
ClientSecret string `mapstructure:"client_secret" json:"client_secret" validate:"required_with=ClientID"` |
Adding modeoptions to config
Support a separate ers connection in the sdk