fix: Update OpenTDF SDK dependency version to 0.7.5 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded the SDK version from 0.7.3 to 0.7.5 in the `pom.xml` file. This update is necessary for compatibility with new features and bug fixes provided in the latest SDK release.
mkleene
reviewed
Oct 31, 2024
|
It looks like this is the only place that needs to be updated: https://github.com/opentdf/nifi/blob/main/nifi-tdf-processors/src/main/java/io/opentdf/nifi/ConvertFromZTDF.java#L75 |
Unused imports were removed to clean up the code. Additionally, the assertion verification keys list population and usage were eliminated to simplify the TDF reading logic in the processFlowFiles method.
|
mkleene
approved these changes
Nov 1, 2024
pflynn-virtru
commented
Nov 1, 2024
| @@ -65,14 +62,15 @@ public ConvertFromZTDF() { | |||
| @Override | |||
| void processFlowFiles(ProcessContext processContext, ProcessSession processSession, List<FlowFile> flowFiles) throws ProcessException { | |||
| SDK sdk = getTDFSDK(processContext); | |||
| //TODO add assertion verification key list population | |||
There was a problem hiding this comment.
@ttschampel should we Config.withDisableAssertionVerification(true) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the SDK version from 0.7.3 to 0.7.5 in the
pom.xmlfile. This update is necessary for compatibility with new features and bug fixes provided in the latest SDK release.https://github.com/opentdf/java-sdk/releases/tag/v0.7.5
https://github.com/opentdf/java-sdk/releases/tag/v0.7.4