Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code coverage #69

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add code coverage #69

wants to merge 14 commits into from

Conversation

mustyantsev
Copy link
Contributor

@mustyantsev mustyantsev commented Jun 5, 2024

addresses #54

@mustyantsev mustyantsev requested review from a team as code owners June 5, 2024 11:51
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have a minimum set so that we fail the build if it's not met?

@mustyantsev mustyantsev linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link
Member

@ttschampel ttschampel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto morgan's comment. we should add some rules to enforce on the coverage metrics

e.g were jacoco.line.coverage is a maven property with the min line coverage threshold for successful build

   <execution>
                            <id>check</id>
                            <goals>
                                <goal>check</goal>
                            </goals>
                            <configuration>
                                <rules>
                                    <rule>
                                        <element>BUNDLE</element>
                                        <limits>
                                            <limit>
                                                <counter>LINE</counter>
                                                <value>COVEREDRATIO</value>
                                                <minimum>${jacoco.line.coverage}</minimum>
                                            </limit>
                                        </limits>
                                    </rule>
                                </rules>
                            </configuration>
                        </execution>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage
3 participants