Updated gems and fixed tests #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a selenium upgrade will let us remove webdriver: titusfortner/webdrivers#247 (comment) |
|
Removing webdrivers requires updating selenium-webdrivers which requires ruby 3. I tried to update it but ran into other issues so I think for now I'll try to just fix the tests in ruby 2.7. The tests already work locally but something is wrong in GH actions. |
|
I'm going to ignore the migrations failure since it's a gem issue (it cannot install the gems from the base commit due to the Chrome changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just do we can deploy something that is not failing tests