Focus on main when content changes

[RoyEJohnson]

DISCO-198

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/app/content/components/Page/scrollToTopOrHashManager.ts

Function	Unhandled Issue
scrollToTop	TypeError: Cannot read properties of null (reading 'tabIndex') resetTabIndex(rex/releases/v4/aff2e9c/static... Event Count: 1 Affected Users: 4

---

_{Did you find this useful? React with a 👍 or 👎}

[Dantemss]

I feel like in principle it should work

[Malar-Natarajan]

@RoyEJohnson The CI check Test is failing. Could you please have a look.

[TomWoodward]

logic is looking cleaner now, although now that i'm looking at where you changed the code in scrollToTargetOrTop i'm wondering if it would be best to focus the target instead of the whole content when linking to a specific target

[TomWoodward]

also that built CI check needs to be fixed

[RoyEJohnson]

Some scroll-to targets are not focusable. Footnotes, for example, are simply divs. They have id's so you can scroll to them, but no tabindex, so they don't focus.

[TomWoodward]

i wonder what the intended screen reader functionality is there.... surely if its scrolling to a target on the page its not supposed to start reading from the top of the content

[RoyEJohnson]

It would be reasonable for screenreaders to recognize that content has scrolled and start reading visible content.

[RoyEJohnson]

I don't think I made any net changes to what's actually here, but the build test works now. All I did was restore some old versions of files to see what caused the test to fail. Then I got rid of those changes and squashed a few commits.

[TomWoodward]

Somehow I feel like the screen reader is not going to do the right thing here with the target scrolling, but I'll approve what you have working so far