Skip to content

Commit

Permalink
Make highlight Actions menu items (Edit and Delete) buttons
Browse files Browse the repository at this point in the history
[DISCO-307]
For clarity, changed `ol` to `menu`
Also simplified return value of DropdownItem.
  • Loading branch information
RoyEJohnson committed Sep 18, 2024
1 parent 2f2d989 commit bf58aa1
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/app/components/Dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ return <FormattedMessage id={message}>
tabIndex={0}
onClick={onClick}
target={target}
onMouseEnter={focusMe}
{...analyticsDataProps}
>{prefix}{msg}</a>
// Safari support tab-navigation of buttons; this operates with space or Enter
Expand Down
2 changes: 0 additions & 2 deletions src/app/components/__snapshots__/DotMenu.spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ exports[`Dropdown matches snapshot 1`] = `
<a
href="/wooo"
onClick={[Function]}
onMouseEnter={[Function]}
role="button"
tabIndex={0}
>
Expand Down Expand Up @@ -516,7 +515,6 @@ exports[`Dropdown matches snapshot on right align 1`] = `
<a
href="/wooo"
onClick={[Function]}
onMouseEnter={[Function]}
role="button"
tabIndex={0}
>
Expand Down
2 changes: 0 additions & 2 deletions src/app/components/__snapshots__/Dropdown.spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ exports[`Dropdown matches snapshot 1`] = `
<a
href="/wooo"
onClick={[Function]}
onMouseEnter={[Function]}
role="button"
tabIndex={0}
>
Expand Down Expand Up @@ -479,7 +478,6 @@ exports[`Dropdown matches snapshot for tab hidden (open) 1`] = `
<a
href="/wooo"
onClick={[Function]}
onMouseEnter={[Function]}
role="button"
tabIndex={0}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,6 @@ exports[`ContextMenu match snapshot when open 1`] = `
<a
data-analytics-region="MH gotohighlight"
href="/link/to/highlight"
onMouseEnter={[Function]}
role="button"
tabIndex={0}
target="_blank"
Expand Down

0 comments on commit bf58aa1

Please sign in to comment.