Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aodh to autoscaling #194

Conversation

vyzigold
Copy link
Contributor

This PR adds aodh to the autoscaling api.

Because the autoscaling controller got quite big, I decided to split it to 3 (4 in the future) files. controllers/autoscaling_controller.go for some common code and /controllers/prometheus_controller.go, /controllers/aodh_controller for the prometheus and aodh related code.

The controller passes the prometheus host and port values to the aodh-evaluator container as expected by the observability client, which will be used for autoscaling in the future.

The functionality of aodh is a bit hard to test at the moment, because we don't have a supported storage for it (gnocchi at this moment, prometheus is coming in the future) we can't create any alarms. But I was able to at least execute openstack alarm list from the openstackclient container. This resulted in an empty response (expected), but most importantly it didn't produce any error in any of the aodh containers or the operator pod.

There is also a related patch to install_yamls to add the required aodh and database passwords to the osp-secret: openstack-k8s-operators/install_yamls#541

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyzigold
Once this PR has been reviewed and has the lgtm label, please assign jlarriba for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

Hi @vyzigold. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlarriba
Copy link
Collaborator

/ok-to-test

@vyzigold
Copy link
Contributor Author

I'll close and reopen this exact PR to get it tested by the new functional tests.

@vyzigold vyzigold closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants