Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscaling prometheus #172

Conversation

vyzigold
Copy link
Contributor

@vyzigold vyzigold commented Sep 4, 2023

This pull request adds a new api. This api will be used for the planed autoscaling feature.

Part of this PR is:

  • Possibility to automatically deploy prometheus with the help of the observability-operator (it's assumed, that the operator is already installed)
  • The PR also allows to specify a user-deployed prometheus by specifying the host and port parameters.
  • The whole autoscaling can be enabled and disabled by the autoscaling.enabled parameter. Right now I left it disabled by default. Because the autoscaling feature will need more PRs to start working.

In the upcoming PRs this api will by extended to also deploy aodh and a service / pod monitor to get the autoscaling data to the prometheus.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

Hi @vyzigold. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@paramite paramite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this yet, but seems legit.

@vyzigold
Copy link
Contributor Author

vyzigold commented Sep 6, 2023

I rebased on top of master.

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@openshift-ci openshift-ci bot removed the lgtm label Sep 11, 2023
@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paramite, vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1c3d089 into openstack-k8s-operators:main Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants