Update placementapi to use service override #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stuggi
requested review from
gibizer and
abays
and removed request for
bogdando
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 4, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 4, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
force-pushed
the
handle_ingress
branch
2 times, most recently
from
c88a198
to
52717d7
Compare
SeanMooney
reviewed
Aug 7, 2023
api/v1beta1/placementapi_types.go
Outdated
| // APIOverrideSpec to override the generated manifest of several child resources. | ||
| type APIOverrideSpec struct { | ||
| // Override configuration for the Service created to serve traffic to the cluster. | ||
| Service []service.OverrideSpec `json:"service,omitempty"` |
There was a problem hiding this comment.
i looked at openstack-k8s-operators/lib-common#313 but didnt see where the service orride type is defined.
we probably want to be fairly strict in what can be overrinde if we expose this interface.
for example we likely do not want to allow the names to be modified but perhaps timeouts or service type might be ok
can you point me to the definition of this datastucture.
any change of the filed in this datastucture will eventually require the service operators to rev ther CRD version so i would like to understand what exactly is in this before we add it to the CRD.
There was a problem hiding this comment.
is this it.
if so i think that is overly broad as it seams to container the core service service spc which would mean any part fo the service could be overridden which is not a maintainable interface.
There was a problem hiding this comment.
yes, right now its label,annotations and the full spec. I kept it for now to be in sync with the rabbitmq operators, but we could e.g. limit the spec to Type, SessionAffinity, loadBalancerSourceRanges, ExternalName, ExternalTrafficPolicy, SessionAffinityConfig, IPFamilyPolicy, LoadBalancerClass and InternalTrafficPolicy
There was a problem hiding this comment.
i think i would prefer that. what I'm concerned about is an end user changing something that breaks our assumptions like the sector for the pods
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 7, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 8, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 8, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 8, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 10, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 10, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 11, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 11, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 17, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 5, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 6, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 7, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 7, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 8, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
|
closing in favor of #61 |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 14, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 18, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 22, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 25, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Oct 2, 2023
Creates the route for the placementapi, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/placement-operator#48 Jira: OSP-26690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template.
Jira: OSP-26690
Depends-On: openstack-k8s-operators/lib-common#313