Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry for Azure GitOps with capability.ThinPack #891

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Aug 4, 2023

More info in go-git/go-git#613 .

@stuggi stuggi requested review from abays and removed request for dprince August 4, 2023 14:04
@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@stuggi stuggi requested a review from dprince August 4, 2023 14:04
@stuggi
Copy link
Contributor Author

stuggi commented Aug 4, 2023

before

2023-08-04T13:17:36.345Z        INFO    controllers.OpenStackConfigGenerator    Get "http://heat-default.openstack.svc:8004/v1/admin/stacks/overcloud": dial tcp: lookup heat-default.openstack.svc: no such host   {
"ObjectType": "*v1beta1.OpenStackConfigGenerator", "ObjectNamespace": "openstack", "ObjectName": "default"}                                                                                                          
2023-08-04T13:17:36.345Z        ERROR   Reconciler error        {"controller": "openstackconfiggenerator", "controllerGroup": "osp-director.openstack.org", "controllerKind": "OpenStackConfigGenerator", "OpenStackC
onfigGenerator": {"name":"default","namespace":"openstack"}, "namespace": "openstack", "name": "default", "reconcileID": "51a3144c-b692-4ff4-853d-2e5a33d7a27a", "error": "empty git-upload-pack given"}  
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                                                                                                
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326                                                                                                                 
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                                             
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273                                                                                                                 
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2                                                                                                                                   
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234     

with patch

2023-08-04T13:55:51.270Z        INFO    controllers.OpenStackConfigGenerator    Failed to create Git repo: empty git-upload-pack given

2023-08-04T13:55:51.270Z        INFO    controllers.OpenStackConfigGenerator    retrying with capability.ThinPack transport capability, required for Azure DevOps

@stuggi
Copy link
Contributor Author

stuggi commented Aug 4, 2023

/cherry-pick v1.3.x

@openshift-cherrypick-robot

@stuggi: once the present PR merges, I will cherry-pick it on top of v1.3.x in a new PR and assign it to you.

In response to this:

/cherry-pick v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 91f0184 into openstack-k8s-operators:master Aug 4, 2023
3 checks passed
@openshift-cherrypick-robot

@stuggi: new pull request created: #892

In response to this:

/cherry-pick v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stuggi
Copy link
Contributor Author

stuggi commented Aug 4, 2023

for reference, tested with free Azure DevOps at https://azure.microsoft.com/en-us/products/devops/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants