Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local build of OSPdO agent for RHEL 9 environments #1103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abays
Copy link
Contributor

@abays abays commented Nov 4, 2024

For some reason we use CGO_ENABLED=1 for the OSPdO agent build. We do not use this for the operator build itself [1]. When it is enabled and the agent is built on a RHEL 9 machine, the resulting image will crashloop when deployed in a 4.16 cluster:

# oc logs openstack-677fbd7745-7pljr -c osp-provision-ip-discovery-agent
/osp-director-agent: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /osp-director-agent)
/osp-director-agent: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /osp-director-agent)

We should align this flag between the agent build and the operator build so that we are consistent and avoid the aforementioned issue.

[1]

RUN if [ -f $CACHITO_ENV_FILE ] ; then source $CACHITO_ENV_FILE ; fi ; CGO_ENABLED=0 GO111MODULE=on go build ${GO_BUILD_EXTRA_ARGS} -a -o ${DEST_ROOT}/manager main.go

@openshift-ci openshift-ci bot requested review from dprince and stuggi November 4, 2024 10:56
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but lets get some feedback from @dprince who created it initially with CGO_ENABLED=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants