Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing square brackets in IPv6 ALLOWED_HOSTS #344

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add missing square brackets in IPv6 ALLOWED_HOSTS #344

merged 1 commit into from
Jul 11, 2024

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Jul 11, 2024 •
edited by openshift-ci bot
Loading

Closes: OSPRH-8554

@olliewalsh olliewalsh requested a review from hjensas July 11, 2024 13:58
@openshift-ci openshift-ci bot requested review from abays and viroel July 11, 2024 13:58
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hjensas
hjensas reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
@olliewalsh
Copy link
Contributor Author

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot
Copy link

@olliewalsh: once the present PR merges, I will cherry-pick it on top of 18.0.0-proposed in a new PR and assign it to you.

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh olliewalsh merged commit add443e into openstack-k8s-operators:main Jul 11, 2024
5 of 6 checks passed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@olliewalsh: new pull request created: #346

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjensas hjensas hjensas left review comments

@abays abays Awaiting requested review from abays

@viroel viroel Awaiting requested review from viroel

Assignees

@hjensas hjensas

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olliewalsh @openshift-cherrypick-robot @hjensas