Ensure nodeSelector logic is consistent for all operators #473
Conversation
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, olliewalsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/heat-operator-build-deploy-kuttl |
|
@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/heat-operator-build-deploy-kuttl In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override rdoproject.org/github-check |
|
@olliewalsh: Overrode contexts on behalf of olliewalsh: rdoproject.org/github-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1c476cf
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr1 |
|
@olliewalsh: new pull request created: #474 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nodeSelectors are not currently applied consistently across all operators.
Some do not support nodeSelectors at all - will be implemented in this series of pull requests.
Some do not apply them to every pod (jobs/cronjobs esp) - will be resolved in this series of pull requests.
Some do not apply a node selector update correctly, only when not initially set.
Some support nodeSelectors but do not inherit the default nodeSelector from the OpenstackControlPlane CR.
Jira: OSPRH-10734