Improve automated support for local webhooks #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abays
requested review from
bshephar
and removed request for
dprince and
viroel
bshephar
approved these changes
Oct 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0a7f395
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
make run-with-webhooktarget to trapSIGINTandSIGTERMso as to callclean_local_webhook.shin such a scenario. This way, a user can run the operator locally and automatically have the local webhooks removed when they finish running the operator viactrl+c.Also creates a backup of any existing OLM CSV for the operator while preparing to run the operator locally with webhooks, if the current CSV has a deployment
replicascount greater than zero and/or there arewebhookdefinitionspresent. That backup can then be easily re-applied to restore OLM CSV defaults viaoc patchby the user at their convenience.