-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate AuthEncryptionKey length #432
Validate AuthEncryptionKey length #432
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/456c7e2629da4ed8a6cce12c998fda43 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 35s |
If a user provides a AuthEncryptionKey less than 32 characters, the Heat service will fail to start and pods will CrashLoopBackOff. This change validates the length of the provided value to ensure we can return an error early rather than waiting until the service is trying to initialize. Jira: https://issues.redhat.com/browse/OSPRH-10507 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
1e7f876
to
cf92c07
Compare
This change adjusts the tests for the HeatAuthEncryptionKey length validation. It also changes the name of the Key in the map to reflect documented recommendations. Jira: https://issues.redhat.com/browse/OSPRH-10508 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
9da5b18
to
e48838a
Compare
Jira: https://issues.redhat.com/browse/OSPRH-10509 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test heat-operator-build-deploy-kuttl |
9bd221e
into
openstack-k8s-operators:main
If a user provides a AuthEncryptionKey less than 32 characters, the Heat service will fail to start and pods will CrashLoopBackOff. This change validates the length of the provided value to ensure we can return an error early rather than waiting until the service is trying to initialize.
Jira: https://issues.redhat.com/browse/OSPRH-10506