Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate AuthEncryptionKey length #432

Conversation

bshephar
Copy link
Collaborator

@bshephar bshephar commented Oct 3, 2024

If a user provides a AuthEncryptionKey less than 32 characters, the Heat service will fail to start and pods will CrashLoopBackOff. This change validates the length of the provided value to ensure we can return an error early rather than waiting until the service is trying to initialize.

Jira: https://issues.redhat.com/browse/OSPRH-10506

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/456c7e2629da4ed8a6cce12c998fda43

openstack-k8s-operators-content-provider FAILURE in 7m 35s
⚠️ heat-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

If a user provides a AuthEncryptionKey less than 32 characters, the Heat service
will fail to start and pods will CrashLoopBackOff. This change validates the
length of the provided value to ensure we can return an error early rather
than waiting until the service is trying to initialize.

Jira: https://issues.redhat.com/browse/OSPRH-10507
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change adjusts the tests for the HeatAuthEncryptionKey length
validation. It also changes the name of the Key in the map to reflect documented
recommendations.

Jira: https://issues.redhat.com/browse/OSPRH-10508
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
@bshephar bshephar force-pushed the validate-auth-enc-key branch 3 times, most recently from 9da5b18 to e48838a Compare October 3, 2024 04:15
Jira: https://issues.redhat.com/browse/OSPRH-10509
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
@bshephar bshephar marked this pull request as ready for review October 3, 2024 14:18
@openshift-ci openshift-ci bot requested review from lewisdenny and rabi October 3, 2024 14:18
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 7, 2024
@fao89
Copy link
Contributor

fao89 commented Oct 7, 2024

/test heat-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 9bd221e into openstack-k8s-operators:main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants