Skip to content

Commit

Permalink
Disable Webhooks
Browse files Browse the repository at this point in the history
This change builds the Operator bundle with ENABLE_WEBHOOKS=false.
This is due to the duplication of webhook logic since openstack-operator
imports and runs this webhook at the OpenStackControlPlane level. Therefor,
having the webhook run by the service operator is a needless duplication
of this webhook logic.

Jira: https://issues.redhat.com/browse/OSPRH-11198
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
  • Loading branch information
bshephar committed Nov 21, 2024
1 parent 1c476cf commit 9052c71
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,6 @@ COPY --from=builder ${DEST_ROOT}/templates ${OPERATOR_TEMPLATES}
USER $USER_ID

ENV PATH="/:${PATH}"
ENV ENABLE_WEBHOOKS="${ENABLE_WEBHOOKS}"

ENTRYPOINT ["/manager"]
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ ENVTEST_K8S_VERSION = 1.29
# Set minimum Go version
GOTOOLCHAIN_VERSION ?= go1.21.0

ENABLE_WEBHOOKS ?= true

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
GOBIN=$(shell go env GOPATH)/bin
Expand Down

0 comments on commit 9052c71

Please sign in to comment.