Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nodeSelector logic is consistent for all operators #657

Merged

Conversation

olliewalsh
Copy link
Contributor

nodeSelectors are not currently applied consistently across all operators.

Some do not support nodeSelectors at all - will be implemented in this series of pull requests.
Some do not apply them to every pod (jobs/cronjobs esp) - will be resolved in this series of pull requests.
Some do not apply a node selector update correctly, only when not initially set.
Some support nodeSelectors but do not inherit the default nodeSelector from the OpenstackControlPlane CR.

Jira: OSPRH-10734

@olliewalsh
Copy link
Contributor Author

/test precommit-check

@olliewalsh
Copy link
Contributor Author

/test images

@olliewalsh
Copy link
Contributor Author

/override ci/prow/glance-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/glance-operator-build-deploy-kuttl

In response to this:

/override ci/prow/glance-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor Author

/override ci/prow/glance-operator-build-deploy-tempest

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/glance-operator-build-deploy-tempest

In response to this:

/override ci/prow/glance-operator-build-deploy-tempest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor Author

/test functional

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@olliewalsh: new pull request created: #659

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants