Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0-fr1] Better Error messages #655

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 18, 2024

This is an automated cherry-pick of #650

Jira: https://issues.redhat.com/browse/OSPRH-11209

/assign fmount

Build better error messages to clarify the reason of an invalid GlanceAPI.
Update functional tests and clean up some code.

Jira: https://issues.redhat.com/browse/OSPRH-11209

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
Copy link
Contributor

fmount commented Nov 18, 2024

/test glance-operator-build-deploy-tempest

2 similar comments
@fmount
Copy link
Contributor

fmount commented Nov 18, 2024

/test glance-operator-build-deploy-tempest

@fmount
Copy link
Contributor

fmount commented Nov 18, 2024

/test glance-operator-build-deploy-tempest

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 402f775 into openstack-k8s-operators:18.0-fr1 Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants