Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Glance s3 config with s3_store_cacert config option #652

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Nov 12, 2024

As per [1][2] s3_store_cacert option must be set when Glance is configured with an s3 backend and needs to interact with an https endpoint, otherwise an image upload fails with the error [3].

[1] https://bugs.launchpad.net/glance/+bug/2030825
[2] https://review.opendev.org/c/openstack/glance_store/+/893980
[3] https://paste.opendev.org/show/bRAFzHDTTGqQA6cG4NEd/

Jira: https://issues.redhat.com/browse/OSPRH-11369

Copy link
Contributor

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just merged https://code.engineering.redhat.com/gerrit/c/glance_store/+/454102 in [rhos-18.0-trunk-patches], so we need to make sure this is now available.

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor Author

fmount commented Nov 22, 2024

/retest

2 similar comments
@fmount
Copy link
Contributor Author

fmount commented Nov 22, 2024

/retest

@fmount
Copy link
Contributor Author

fmount commented Nov 27, 2024

/retest

@fmount
Copy link
Contributor Author

fmount commented Nov 27, 2024

/test glance-operator-build-deploy-kuttl

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
Copy link
Contributor Author

fmount commented Nov 27, 2024

/test glance-operator-build-deploy-kuttl

@konan-abhi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7933605 into openstack-k8s-operators:main Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants