Compute GlanceAPI storage configuration hash #648
Merged
+57
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
storage-conf-hash
branch
from
039f907
to
ad791b6
Compare
fmount
force-pushed
the
storage-conf-hash
branch
from
ad791b6
to
0651443
Compare
fmount
force-pushed
the
storage-conf-hash
branch
from
0651443
to
963e95d
Compare
Add .Spec.Storage configuration and .Spec.ImageCache to the Hash based on the enabled_backends. This will trigger an API refresh not only when the enabled_backends string changes, but also if the Storage interface or imageCache (e.g. storageClass, storageRequest, externalStorage) changes as part of any day2 ops. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
/test glance-operator-build-deploy-tempest |
konan-abhi
approved these changes
Nov 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test functional |
|
/test glance-operator-build-deploy-kuttl |
1 similar comment
|
/test glance-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 125104b
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.Spec.Storageand.Spec.ImageCacheto the Hash based on theenabled_backends.This will trigger an API refresh not only when the
enabled_backendsstring changes, but also if theStorage interfaceor theImageCacheconfig (e.g.storageClass,storageRequest,externalStorage) is updated as part of any day2 operation.Jira: https://issues.redhat.com/browse/OSPRH-11211