Automate OLM cleanup for running local operator w/ webhooks #639
Conversation
hack/configure_local_webhook.sh
Outdated
|
|
||
| if [ -n "${CSV_NAME}" ]; then | ||
| oc patch "${CSV_NAME}" -n openstack-operators --type=json -p="[{'op': 'replace', 'path': '/spec/install/spec/deployments/0/spec/replicas', 'value': 0}]" | ||
| oc patch "${CSV_NAME}" -n openstack-operators --type=json -p="[{'op': 'replace', 'path': '/spec/webhookdefinitions', 'value': []}]" |
There was a problem hiding this comment.
As a follow up, but just out of curiosity, do we want to update [1] to reflect this approach? (replace w/ an empty array instead of remove).
[1] https://github.com/openstack-k8s-operators/dev-docs/blob/main/webhooks.md#disabling-webhooks
There was a problem hiding this comment.
Yes. In fact, I had consulted that doc while creating this and realized that this was a better way to do it. 😄
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abays
force-pushed
the
olm_webhook_cleanup
branch
from
d135412
to
2902d3b
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 32b669e
into
openstack-k8s-operators:main
When using make
run-with-webhook, local versions of the operator and its webhooks are added to the cluster. If the operator was previously installed via OLM, then there might be lingering webhooks from that installation. We've previously been assuming that the user would manually remove them, but we should just get rid of them ourselves since those OLM webhooks need to be deleted anyhow for the local webhooks to function unimpeded. We can also automatically scale down the operator's OLM deployment in such a scenario.