Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cronJob envTests #627

Merged

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Sep 23, 2024

This patch improves the existing envTests to include cronJob verification and update. It shows how an update in the Glance top level CR is reflected in an update of the CronJob schedule. In addition, the cronJob name now uses instance.Name instead of hardcoding ServiceName (if the unique CR name feature is used it will reflect the name of the global CR).

@fmount
Copy link
Contributor Author

fmount commented Sep 23, 2024

/test glance-operator-build-deploy-kuttl

2 similar comments
@fmount
Copy link
Contributor Author

fmount commented Sep 23, 2024

/test glance-operator-build-deploy-kuttl

@abays
Copy link
Contributor

abays commented Sep 25, 2024

/test glance-operator-build-deploy-kuttl

@fmount
Copy link
Contributor Author

fmount commented Sep 25, 2024

I see a failure in fips check:

+---------------------------+-----------------+-----------------------------------------------+-------------------------------------------------------------------------------------+
| OPERATOR NAME             | EXECUTABLE NAME | STATUS                                        | IMAGE                                                                               |
+---------------------------+-----------------+-----------------------------------------------+-------------------------------------------------------------------------------------+
| glance-operator-container | /manager        | go binary does not contain required symbol(s) | docker.io/rdotripleomirror/glance-operator:84e3e3e940ef9219475f-1838860824643375104 |
+---------------------------+-----------------+-----------------------------------------------+-------------------------------------------------------------------------------------+

which is not related to kuttl, but I suspect is related to the recent bump: I probably need to rebase this patch.

@fmount
Copy link
Contributor Author

fmount commented Sep 25, 2024

ok as mentioned in a diff thread, we need to wait for a patch that pins the go-toolset

@abays
Copy link
Contributor

abays commented Sep 25, 2024

ok as mentioned in a diff thread, we need to wait for a patch that pins the go-toolset

I think there's a workaround in place now: openshift/release#57159

@abays
Copy link
Contributor

abays commented Sep 25, 2024

/retest

@fmount
Copy link
Contributor Author

fmount commented Sep 27, 2024

/test glance-operator-build-deploy-kuttl

@fmount
Copy link
Contributor Author

fmount commented Sep 27, 2024

I'm not sure why kuttl is failing there: I need to figure that out

@fmount fmount force-pushed the cronjob_envtest branch 2 times, most recently from 069adfb to 27cab20 Compare September 27, 2024 19:46
This patch improves the existing envTest bucket to include cronJob
verification and update. It shows how an update in the Glance top level
CR is reflected in an update of the CronJob schedule. In addition, the
cronJob name now uses instance.Name instead of hardcoding the
ServiceName (if the "unique CR" name feature is used it will reflect the
name of the global CR).

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9305b4d into openstack-k8s-operators:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants