-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cronJob envTests #627
Add cronJob envTests #627
Conversation
/test glance-operator-build-deploy-kuttl |
2 similar comments
/test glance-operator-build-deploy-kuttl |
/test glance-operator-build-deploy-kuttl |
I see a failure in fips check:
which is not related to kuttl, but I suspect is related to the recent bump: I probably need to rebase this patch. |
84e3e3e
to
33ac306
Compare
ok as mentioned in a diff thread, we need to wait for a patch that pins the go-toolset |
I think there's a workaround in place now: openshift/release#57159 |
/retest |
/test glance-operator-build-deploy-kuttl |
I'm not sure why kuttl is failing there: I need to figure that out |
069adfb
to
27cab20
Compare
This patch improves the existing envTest bucket to include cronJob verification and update. It shows how an update in the Glance top level CR is reflected in an update of the CronJob schedule. In addition, the cronJob name now uses instance.Name instead of hardcoding the ServiceName (if the "unique CR" name feature is used it will reflect the name of the global CR). Signed-off-by: Francesco Pantano <fpantano@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9305b4d
into
openstack-k8s-operators:main
This patch improves the existing
envTests
to includecronJob
verification and update. It shows how an update in theGlance
top levelCR
is reflected in an update of theCronJob
schedule. In addition, thecronJob
name now usesinstance.Name
instead of hardcodingServiceName
(if theunique CR
name feature is used it will reflect the name of the global CR).