Ensure required spec fields are given #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec is required so that the controller can look up passwords.
... because it is required to generate the config file.
|
/test glance-operator-build-deploy-tempest |
1 similar comment
|
/test glance-operator-build-deploy-tempest |
fmount
approved these changes
Aug 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, kajinamit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit f311345
into
openstack-k8s-operators:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several spec fields of GlanceAPI CR with optional mark are in fact required to deploy services.
This ensures these spec fields are required so that the proper validation failure is returned early.