Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DCN custom playbooks #2450

Closed

Conversation

sbekkerm
Copy link
Contributor

Key changes:

  • Added DCN-specific playbooks to the playbook/dcn folder.
  • Moved Jinja templates from the architecture repository into the roles/ci_gen_kustomize_values/templates/dcn folder.

There are two playbooks. These playbooks will be executed in a hook after the control plane has been deployed.

  • deploy-dcn.yml: This playbook generates a list of network ranges and sequentially calls deploy-edpm.yml to deploy the EDPM nodesets based on the defined networking environment.

  • deploy-edpm.yml: This playbook focuses on the deployment of the EDPM nodeset and the Ceph cluster relating to DCN sites. It leverages Jinja templates to dynamically generate the values.yaml and service-values.yaml files required for Kustomize.

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

Hi @sbekkerm. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot marked this pull request as draft October 14, 2024 09:08
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/464cdea0779b410da7139c9045b3ea61

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 58s
cifmw-pod-k8s-snippets-source FAILURE in 4m 40s
cifmw-pod-pre-commit FAILURE in 7m 44s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 02s
✔️ build-push-container-cifmw-client SUCCESS in 37m 05s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 10s

@fultonj fultonj self-requested a review October 14, 2024 13:20
Introduced the DCN custom playbook and its corresponding Jinja values
templates.
}}

- name: Deploy EDPM
include_tasks: deploy-edpm.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this include_tasks be changed into an include_role which includes a new role like ci_dcn_site.

Then move all the j2 files in this PR and the deploy-edpm.yml tasks file into the new ci_dcn_site role?

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/16d12a2125a7408b8b74a68fe2780973

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 26s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 10m 53s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 6m 45s
cifmw-pod-pre-commit FAILURE in 9m 14s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 25s
✔️ build-push-container-cifmw-client SUCCESS in 40m 20s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 8m 46s

@fultonj
Copy link
Contributor

fultonj commented Oct 15, 2024

Obsoleted by #2458

@fultonj fultonj closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants