New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-IPV6 DT #421

Merged

softwarefactory-project-zuul merged 1 commit into openstack-k8s-operators:main from shiftstack:osasinfra-ipv6

Nov 25, 2024

+1,706 −2

Contributor

rlobillo commented Oct 18, 2024

A DT for deploying OpenShift on OpenStack using IPV6.

This DT is inspired on the existing OSASINFRA DT but configuring the IPV6 endpoints.

openshift-ci bot requested review from fultonj and raukadah

October 18, 2024 10:42

openshift-ci bot commented Oct 18, 2024

Hi @rlobillo. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the needs-ok-to-test label

rlobillo marked this pull request as draft

October 18, 2024 11:52

openshift-ci bot added the do-not-merge/work-in-progress label

rlobillo force-pushed the osasinfra-ipv6 branch 2 times, most recently from 7f1a8c8 to 0faa80a Compare

October 22, 2024 12:30

rlobillo mentioned this pull request

Add osasinfra-ipv6 network-values template openstack-k8s-operators/ci-framework#2481

Merged

rlobillo force-pushed the osasinfra-ipv6 branch from 0faa80a to b4ca192 Compare

October 22, 2024 21:03

Contributor

softwarefactory-project-zuul bot commented Oct 22, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/013cb64fd36d4085ad14266925c9c500

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 47s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 13s

rlobillo force-pushed the osasinfra-ipv6 branch from b4ca192 to b2abfa1 Compare

October 25, 2024 10:18

Contributor

softwarefactory-project-zuul bot commented Oct 25, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/acc4ec87c26c4e24980c6a25720bba0b

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 39s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 15s

rlobillo force-pushed the osasinfra-ipv6 branch from b2abfa1 to beb3db2 Compare

October 25, 2024 10:47

Contributor

softwarefactory-project-zuul bot commented Oct 25, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/43e445b092d240db866681cf32e9a694

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 39s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 11s

Contributor Author

rlobillo commented Oct 25, 2024

recheck

Contributor

softwarefactory-project-zuul bot commented Oct 25, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0632cdf7a67647bbbd00cce256939599

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 42s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 08s

hjensas reviewed

View reviewed changes

examples/dt/osasinfra-ipv6/edpm-pre-ceph/nodeset/values.yaml Outdated Show resolved Hide resolved

rlobillo force-pushed the osasinfra-ipv6 branch from beb3db2 to 1cf2af3 Compare

October 29, 2024 14:16

Contributor

softwarefactory-project-zuul bot commented Oct 29, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df9d6f2200214e47a5f67c0110a650d2

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 57s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 33s

rlobillo force-pushed the osasinfra-ipv6 branch from 1cf2af3 to 653dd6a Compare

October 30, 2024 13:54

Contributor

softwarefactory-project-zuul bot commented Oct 30, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6512d0ab2b904eaa9120e71c537d6ab2

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 5m 05s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 04s

rlobillo force-pushed the osasinfra-ipv6 branch from 653dd6a to 4a46486 Compare

October 30, 2024 20:36

Contributor

softwarefactory-project-zuul bot commented Oct 30, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f35f332320f54178b8ede2e81bd81729

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 41s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 57s

rlobillo force-pushed the osasinfra-ipv6 branch from 4a46486 to 85f2236 Compare

October 30, 2024 21:04

Contributor

softwarefactory-project-zuul bot commented Oct 30, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c81e61370fe4c9d89287c8fb997c719

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 42s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 05s

rlobillo force-pushed the osasinfra-ipv6 branch from 85f2236 to 018a080 Compare

November 4, 2024 10:01

Contributor

softwarefactory-project-zuul bot commented Nov 4, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ebc2bac28a0447e1a9dc37dae29a3d28

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 46s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 17s

rlobillo force-pushed the osasinfra-ipv6 branch from 018a080 to eb6fac6 Compare

November 4, 2024 14:59

Contributor

softwarefactory-project-zuul bot commented Nov 4, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ba1834d06fbd462c872af3583ef6d089

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 39s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 3m 10s

Contributor

softwarefactory-project-zuul bot commented Nov 5, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2f49998c9e46452aba10468f5a7a1c65

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 5m 06s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 05s

rlobillo added ready-review and removed do-not-merge/work-in-progress labels

Contributor Author

rlobillo commented Nov 13, 2024 •

edited

Loading

Ready for review!

/cc @mandre
/cc @abays

Could you please take a look on this?

Successful installation on https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/build/ad230d0b5a5246feaa3265e22928341b

rhoso-architecture-validate-osasinfra-ipv6 is failing because openstack-k8s-operators/ci-framework#2481 needs to be merged.

rlobillo added the deployment-topology label

rlobillo requested a review from hjensas

November 13, 2024 09:38

abays reviewed

View reviewed changes

Contributor

abays left a comment

+1 from me

mandre reviewed

View reviewed changes

Contributor

mandre left a comment

This is identical to the osasinfra DT for the most part. The only diffs I could find where:

name changed from osasinfra to osasinfra-ipv6
obviously, IP addresses changed from v4 to v6
edpm_network_config_template in edpm-pre-ceph/nodeset/values.yaml:
- dropped nic1
- use the >- block scalar header for the networks ip_netmask
define a storagemgmt subnet in edpm-pre-ceph/nodeset/values.yaml (probably an overlook of the osasinfra DT)

I wish there was a better way than duplicating the whole DT. This is going to be painful maintaining down the line. It feels like we should be able to do better with kustomize.

Simply looking a the content of the DT, LGTM.

rlobillo marked this pull request as ready for review

November 18, 2024 10:33

openshift-ci bot requested a review from cjeanner

November 18, 2024 10:33

Contributor Author

rlobillo commented Nov 18, 2024

This is identical to the osasinfra DT for the most part. The only diffs I could find where:

name changed from osasinfra to osasinfra-ipv6

obviously, IP addresses changed from v4 to v6

edpm_network_config_template in edpm-pre-ceph/nodeset/values.yaml:

dropped nic1

use the >- block scalar header for the networks ip_netmask

define a storagemgmt subnet in edpm-pre-ceph/nodeset/values.yaml (probably an overlook of the osasinfra DT)

I wish there was a better way than duplicating the whole DT. This is going to be painful maintaining down the line. It feels like we should be able to do better with kustomize.

Simply looking a the content of the DT, LGTM.

Thanks @mandre. Your list is correct. There is another difference which is that osasinfra DT uses lib/nncp_ipv6 on dt/osasinfra-ipv6/nncp/kustomization.yaml, while osasinfra DT uses lib/nncp

Contributor

mandre commented Nov 18, 2024

@abays who do we need to get reviews from? From my point of view, this looks good to merge.

Contributor

abays commented Nov 18, 2024

@mandre Maybe @fultonj wants to take a look. If not, I could approve it, but there's a CI error that needs to be addressed first.

Contributor

mandre commented Nov 18, 2024

Oh indeed, I missed the CI failure:

  stderr: 'error: accumulating components: accumulateDirectory: "recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/dt/osasinfra-ipv6/nncp'': accumulating components: accumulateDirectory: \"recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/lib/nncp_ipv6'': fieldPath `data.node_0.node_name` is missing for replacement source ConfigMap.[noVer].[noGrp]/network-values.[noNs]\""'

That must be fixed first, of course.

Contributor Author

rlobillo commented Nov 18, 2024

Oh indeed, I missed the CI failure:

  stderr: 'error: accumulating components: accumulateDirectory: "recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/dt/osasinfra-ipv6/nncp'': accumulating components: accumulateDirectory: \"recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/lib/nncp_ipv6'': fieldPath `data.node_0.node_name` is missing for replacement source ConfigMap.[noVer].[noGrp]/network-values.[noNs]\""'

That must be fixed first, of course.

This error is happening because openstack-k8s-operators/ci-framework#2481 is still not merged.

Contributor Author

rlobillo commented Nov 18, 2024

/retest

Contributor Author

rlobillo commented Nov 18, 2024

recheck

Contributor Author

rlobillo commented Nov 22, 2024

@fultonj Would you mind to take a look on this? Thank you.

fultonj reviewed

View reviewed changes

Contributor

fultonj left a comment

I don't have any major problems with it. I saw a few small things which should be easy to fix.

examples/dt/osasinfra-ipv6/README.md Outdated

+              This is a collection of CR templates that represent a validated Red Hat
+              OpenStack Services on OpenShift deployment following the recommendations from
+              the (OpenShift on OpenStack reference
+              architecture)[https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.2/html-single/reference_architecture_for_deploying_red_hat_openshift_container_platform_on_red_hat_openstack_platform/index]. It has the following characteristics:

Contributor

fultonj Nov 22, 2024

This link not formatted correctly. Please transpose [] and ().

Contributor

fultonj Nov 22, 2024

After the readme is fixed, I'm ok if it merges.

Contributor Author

rlobillo Nov 25, 2024

Done. Thanks John!

Contributor

fultonj commented Nov 22, 2024

Oh indeed, I missed the CI failure:

  stderr: 'error: accumulating components: accumulateDirectory: "recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/dt/osasinfra-ipv6/nncp'': accumulating components: accumulateDirectory: \"recursed accumulation of path ''/home/zuul/src/github.com/openstack-k8s-operators/architecture/lib/nncp_ipv6'': fieldPath `data.node_0.node_name` is missing for replacement source ConfigMap.[noVer].[noGrp]/network-values.[noNs]\""'

That must be fixed first, of course.

This error is happening because openstack-k8s-operators/ci-framework#2481 is still not merged.

I see that rhoso-architecture-validate-osasinfra-ipv6 is now passing.

https://softwarefactory-project.io/zuul/t/rdoproject.org/build/aa69db50d6b44e9f831b26d79d51ccad


          OSASINFRA-IPV6 DT

2627dad

A DT for deploying OpenShift on OpenStack using IPV6.

This DT is inspired on the existing OSASINFRA DT but configuring the
IPV6 endpoints.

rlobillo force-pushed the osasinfra-ipv6 branch from 05c8f2d to 2627dad Compare

November 25, 2024 11:27

abays approved these changes

View reviewed changes

Contributor

abays left a comment

/lgtm
/approve

openshift-ci bot assigned abays

openshift-ci bot added the lgtm label

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rlobillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor

abays commented Nov 25, 2024

recheck-gate

Contributor

softwarefactory-project-zuul bot commented Nov 25, 2024

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/99718e389f1e4193bd6436b8b8383448

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 48s
✔️ rhoso-architecture-validate-osasinfra-ipv6 SUCCESS in 3m 53s

softwarefactory-project-zuul bot merged commit 8cbc28e into openstack-k8s-operators:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fultonj fultonj left review comments

mandre mandre left review comments

abays abays approved these changes

raukadah Awaiting requested review from raukadah

hjensas Awaiting requested review from hjensas

cjeanner Awaiting requested review from cjeanner

Labels

approved deployment-topology lgtm needs-ok-to-test ready-review