Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move automation default vars into seperate scenario files #396

Conversation

rdiazcam
Copy link
Contributor

#374 adds the trigger job which will run different Baremetal VA jobs downstream on different architecture file changes.

Currently automation/vars/default.yaml contains different multiple scenarios, stored in a single file. Trigger job may run unwanted jobs downstream without testing the proper architecture changes.

By moving automations vars into different scenario files allow us to run selective trigger job and test the proper prs.

Let's keep the defaults.yaml file till we finish the migration.

openstack-k8s-operators#374 adds
the trigger job which will run different Baremetal VA jobs downstream on
different architecture file changes.

Currently automation/vars/default.yaml contains different multiple
scenarios, stored in a single file. Trigger job may run unwanted jobs
downstream without testing the proper architecture changes.

By moving automations vars into different scenario files allow us
to run selective trigger job and test the proper prs.

Let's keep the defaults.yaml file till we finish the migration.

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/architecture for 396,f44ce4fc381e1c3f066aef39342786305612880e

Copy link

openshift-ci bot commented Sep 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rdiazcam
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 15, 2024

@rdiazcam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit f44ce4f link true /test unit
ci/prow/images f44ce4f link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rdiazcam rdiazcam closed this Sep 15, 2024
@rdiazcam rdiazcam deleted the move_automation_vars branch September 15, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants