Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bgp_dt01 into its own automation file #384

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Move bgp_dt01 into its own automation file #384

merged 1 commit into from
Sep 4, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Sep 3, 2024

#375 splits the default vars into different scenario files. We need to follow similar pattern for bgp_dt01 also.

Depends-On: openstack-k8s-operators/ci-framework#2267

@raukadah
Move bgp_dt01 into its own automation file
116ab90 
openstack-k8s-operators#375 splits the default vars into different scenario files.
We need to follow similar pattern for bgp_dt01 also.

Depends-On: openstack-k8s-operators/ci-framework#2267

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
@openshift-ci openshift-ci bot added the approved label Sep 3, 2024
@cjeanner
Copy link
Contributor

cjeanner commented Sep 3, 2024

/lgtm

This PR has been integrated in my linter one (#379 ) and it's green now.

@openshift-ci openshift-ci bot added the lgtm label Sep 3, 2024
@cjeanner
Copy link
Contributor

cjeanner commented Sep 3, 2024

(Note: it might require a sync with the bgp team - need to ping them)

@cjeanner
Copy link
Contributor

cjeanner commented Sep 3, 2024

/hold

some tests are done - let's hold it.

@fultonj
Copy link
Contributor

fultonj commented Sep 3, 2024

I'm +2 on this in theory. Holding per Cedric's comments.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marios, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/60423075bab941139e47335339d928fd

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 05942d3 into openstack-k8s-operators:main Sep 4, 2024
9 checks passed
@marios
Copy link

marios commented Sep 4, 2024

didn't expect this to merge with just one approval @raukadah @cjeanner was there something further here?
it looks like the labels didn't work as intended ? (do not merge)

@eduolivares eduolivares added the needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges label Sep 9, 2024
@eduolivares
Copy link
Contributor

removing the label because porting to 18.0.0-proposed doesn't seem to be necessary

@eduolivares eduolivares removed the needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges label Sep 9, 2024
raukadah added a commit to raukadah/architecture that referenced this pull request Sep 10, 2024
@raukadah
Backport default.yaml split patches
23a4e5d 
It backports following patches:
openstack-k8s-operators#375 -  Move automation default vars into seperate scenario files
openstack-k8s-operators#383 - Drop default.yaml file
openstack-k8s-operators#379 - Ensure we have one scenario per automation file
openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
@raukadah raukadah mentioned this pull request Sep 10, 2024
Merged
raukadah added a commit to raukadah/architecture that referenced this pull request Sep 11, 2024
@raukadah
Backport default.yaml split patches
613f451 
It backports following patches:
openstack-k8s-operators#375 -  Move automation default vars into seperate scenario files
openstack-k8s-operators#383 - Drop default.yaml file
openstack-k8s-operators#379 - Ensure we have one scenario per automation file
openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file
openstack-k8s-operators#373 - NFV-HCI minor fixes

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
softwarefactory-project-zuul bot added a commit that referenced this pull request Sep 11, 2024
@softwarefactory-project-zuul
Merge pull request #394 from raukadah/sync_patches
ab2e02a 
Backport default.yaml split patches

It backports following patches:

#375
#383
#379
#384
#373

Reviewed-by: Ella Shulman <ellashulman1@gmail.com>
Reviewed-by: Cédric Jeanneret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marios marios marios approved these changes

@eduolivares eduolivares Awaiting requested review from eduolivares

@cjeanner cjeanner Awaiting requested review from cjeanner

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@marios marios

@cjeanner cjeanner

Labels
approved do-not-merge/hold lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raukadah @cjeanner @fultonj @marios @eduolivares