-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFV-HCI minor fixes #373
NFV-HCI minor fixes #373
Conversation
97618d5
to
7892b1a
Compare
automation/vars/default.yaml
Outdated
@@ -271,8 +271,10 @@ vas: | |||
post_stage_run: | |||
- name: Deploy Ceph | |||
type: playbook | |||
source: "../../playbooks/ceph.yml" | |||
source: "../../hooks/playbooks/ceph-bm.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this listed here: https://github.com/openstack-k8s-operators/ci-framework/tree/main/hooks/playbooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andrew it is in this patch https://github.com/openstack-k8s-operators/ci-framework/pull/2246/files that we are working on getting merged but having that this job is still in development it shouldn't impact any existing job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I'm good with merging this once that CIFMW PR merges.
e0a4508
to
3d18893
Compare
a0e9359
to
c982054
Compare
@eshulman2 Has this been tested? |
1989405
to
d707a8f
Compare
Hi @abays yes it was tested here: https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/build/549e1754d9e140ba9baabbf0fa9804e3 the job failed on some tests but unrelated to architecture, just added a small thing for consistency and going to re-run now to verify. will ping you after the job finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to massage the changes to default.yaml
into #383, as the file is being dropped there and moved elsewhere
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, eshulman2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (gate pipeline). For information on how to proceed, see https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e8f7a4a9bae4d6da067fc933f9b5fe8 ✔️ noop SUCCESS in 0s |
@abays I copied the changes between the default file and the file that should be used after that patch to avoid issues |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3f136a40d2aa460289d7e6e74fd37964 ✔️ noop SUCCESS in 0s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ed4c3b8beca247b9bdbe181534f53a3a ✔️ noop SUCCESS in 0s |
/lgtm |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9f86354485654adb9dfe321f9e53deba ✔️ noop SUCCESS in 0s |
New changes are detected. LGTM label has been removed. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/78c56f9dee2944f7b11dc211b1eaa758 ✔️ noop SUCCESS in 0s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/216f41efd0934690ad5e43bc4de4ee62 ✔️ noop SUCCESS in 0s |
/lgtm all should be in place. I forgot there are some more consistency checks in the repository to ensure all corners are properly covered :). |
recheck-gate |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
c1d4fa5
into
openstack-k8s-operators:main
It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file openstack-k8s-operators#373 - NFV-HCI minor fixes Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
minor fixes for NFV hci deployment