Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFV-HCI minor fixes #373

Conversation

eshulman2
Copy link
Contributor

@eshulman2 eshulman2 commented Aug 21, 2024

minor fixes for NFV hci deployment

@@ -271,8 +271,10 @@ vas:
post_stage_run:
- name: Deploy Ceph
type: playbook
source: "../../playbooks/ceph.yml"
source: "../../hooks/playbooks/ceph-bm.yml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@eshulman2 eshulman2 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew it is in this patch https://github.com/openstack-k8s-operators/ci-framework/pull/2246/files that we are working on getting merged but having that this job is still in development it shouldn't impact any existing job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I'm good with merging this once that CIFMW PR merges.

@eshulman2 eshulman2 force-pushed the hci_fixes branch 2 times, most recently from e0a4508 to 3d18893 Compare August 29, 2024 06:53
@eshulman2 eshulman2 changed the title hci fixes NFV-HCI minor fixes Aug 29, 2024
@eshulman2 eshulman2 requested a review from abays September 1, 2024 06:00
@eshulman2 eshulman2 force-pushed the hci_fixes branch 3 times, most recently from a0e9359 to c982054 Compare September 2, 2024 17:41
@abays
Copy link
Contributor

abays commented Sep 3, 2024

@eshulman2 Has this been tested?

@eshulman2 eshulman2 force-pushed the hci_fixes branch 2 times, most recently from 1989405 to d707a8f Compare September 3, 2024 12:38
@eshulman2
Copy link
Contributor Author

Hi @abays yes it was tested here: https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/build/549e1754d9e140ba9baabbf0fa9804e3 the job failed on some tests but unrelated to architecture, just added a small thing for consistency and going to re-run now to verify. will ping you after the job finishes.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to massage the changes to default.yaml into #383, as the file is being dropped there and moved elsewhere

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 4, 2024
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, eshulman2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
Copy link
Contributor

@eshulman2
Copy link
Contributor Author

@abays I copied the changes between the default file and the file that should be used after that patch to avoid issues

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3f136a40d2aa460289d7e6e74fd37964

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-nfv-ovs-dpdk-sriov-hci FAILURE in 3m 27s

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ed4c3b8beca247b9bdbe181534f53a3a

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-nfv-ovs-dpdk-sriov-hci FAILURE in 3m 27s

@cjeanner
Copy link
Contributor

cjeanner commented Sep 5, 2024

/lgtm
re-adding the label; Gate failed because there was no mock file for this scenario, meaning the cifmw_baremetal_hosts wasn't set.

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9f86354485654adb9dfe321f9e53deba

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-nfv-ovs-dpdk-sriov-hci FAILURE in 3m 38s

Copy link

openshift-ci bot commented Sep 5, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/78c56f9dee2944f7b11dc211b1eaa758

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-nfv-ovs-dpdk-sriov-hci FAILURE in 3m 13s

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/216f41efd0934690ad5e43bc4de4ee62

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-nfv-ovs-dpdk-sriov-hci FAILURE in 3m 12s

@cjeanner
Copy link
Contributor

cjeanner commented Sep 5, 2024

/lgtm all should be in place. I forgot there are some more consistency checks in the repository to ensure all corners are properly covered :).

@cjeanner cjeanner added the lgtm label Sep 5, 2024
@cjeanner
Copy link
Contributor

cjeanner commented Sep 5, 2024

recheck-gate

Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c1d4fa5 into openstack-k8s-operators:main Sep 5, 2024
9 checks passed
raukadah added a commit to raukadah/architecture that referenced this pull request Sep 11, 2024
It backports following patches:
openstack-k8s-operators#375 -  Move automation default vars into seperate scenario files
openstack-k8s-operators#383 - Drop default.yaml file
openstack-k8s-operators#379 - Ensure we have one scenario per automation file
openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file
openstack-k8s-operators#373 - NFV-HCI minor fixes

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
softwarefactory-project-zuul bot added a commit that referenced this pull request Sep 11, 2024
Backport default.yaml split patches

It backports following patches:

#375
#383
#379
#384
#373

Reviewed-by: Ella Shulman <ellashulman1@gmail.com>
Reviewed-by: Cédric Jeanneret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants