Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LACP, balance-tcp and IGMP configs changes #181

Merged
merged 1 commit into from
Jun 10, 2024
Merged

LACP, balance-tcp and IGMP configs changes #181

merged 1 commit into from
Jun 10, 2024

Conversation

Jaganathancse
Copy link
Contributor

This change is to provide configs for LACP,
balance-tcp and IGMP network template on
compute nodes.

@Jaganathancse Jaganathancse changed the title LACP, balance-tcp and IGMP configs changes WIP: LACP, balance-tcp and IGMP configs changes Apr 15, 2024
@leifmadsen leifmadsen added enhancement New feature or request needs-testing Testing proof is required prior to merge triaged Issue has been initially reviewed and triaged and removed triaged Issue has been initially reviewed and triaged labels Apr 29, 2024
@fultonj
Copy link
Contributor

fultonj commented Apr 29, 2024

@Jaganathancse I assume you'll let us know when this is ready for review by removing WIP in the title and getting initial CI green.

@fultonj fultonj added the needs-info Information is requested of the reporter or reviewers label Apr 29, 2024
@Jaganathancse
Copy link
Contributor Author

@Jaganathancse I assume you'll let us know when this is ready for review by removing WIP in the title and getting initial CI green.

@fultonj ack

@Jaganathancse Jaganathancse force-pushed the igmb_blance_tcp_lacp_configs branch 2 times, most recently from 5343a51 to 8cc859d Compare May 6, 2024 07:11
@Jaganathancse Jaganathancse changed the title WIP: LACP, balance-tcp and IGMP configs changes LACP, balance-tcp and IGMP configs changes May 6, 2024
@Jaganathancse Jaganathancse force-pushed the igmb_blance_tcp_lacp_configs branch 5 times, most recently from c4f6b87 to f40b005 Compare May 15, 2024 16:05
LACP, balance-tcp and IGMP configs changes
8eef98c 
This change is to provide configs for LACP,
balance-tcp and IGMP network template on
compute nodes.
@fultonj
Copy link
Contributor

fultonj commented Jun 10, 2024

Is this still needed?

@Jaganathancse
Copy link
Contributor Author

Is this still needed?

yes

@fultonj
Copy link
Contributor

fultonj commented Jun 10, 2024

Has this been tested and is it ready to merge?

fultonj
fultonj approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaganathancse as per our conversation this can be merged.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, Jaganathancse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://review.rdoproject.org/zuul/buildset/1a66c59e1b2643ab975110d8ece7209d

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-ovs-dpdk SUCCESS in 3m 44s
✔️ rhoso-architecture-validate-ovs-dpdk-sriov SUCCESS in 3m 39s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3828c3d into openstack-k8s-operators:main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj approved these changes

@vcandapp vcandapp Awaiting requested review from vcandapp

@karthiksundaravel karthiksundaravel Awaiting requested review from karthiksundaravel

@abays abays Awaiting requested review from abays

Assignees

@fultonj fultonj

Labels
approved enhancement New feature or request lgtm needs-info Information is requested of the reporter or reviewers needs-testing Testing proof is required prior to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaganathancse @fultonj @leifmadsen