Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Staticize dhcp config for eth0 #179

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Apr 15, 2024

Using dhcp for nic1 breaks the dns configuration by updating resolv.conf used by edpm. Reverting to fix current issues and if there is a requirement to use dhcp for nic1 it could be reworked.

This reverts openstack-k8s-operators#157

Using dhcp for  nic1 breaks the dns configuration by updating
resolv.conf used by edpm. Reverting to fix current issues and if
there is a requirement to use dhcp for nic1 it could be reworked.

Signed-off-by: rabi <ramishra@redhat.com>
@rabi rabi changed the title Don't use dhcp for interface Revert Staticize dhcp config for eth0 Apr 15, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's merge this for now and follow-up with some other approach to achieve what was originally needed

/lgtm

@abays abays merged commit e80bb6c into openstack-k8s-operators:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants