Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure wait_conditions starts with specific pattern #163

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Ensure wait_conditions starts with specific pattern #163

merged 1 commit into from
Apr 4, 2024

Conversation

cjeanner
Copy link
Contributor

@cjeanner cjeanner commented Apr 4, 2024

This ensures we're really facing a wait_condition, by checking we're
starting the command by either oc or kubectl (yes, with a space
after the command).

@cjeanner
Ensure wait_conditions starts with specific pattern
31ba8f7 
This ensures we're really facing a wait_condition, by checking we're
starting the command by either `oc ` or `kubectl ` (yes, with a space
after the command).
abays
abays approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abays abays merged commit 107dd5d into openstack-k8s-operators:main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjeanner @abays