Staticize dhcp config for eth0 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to rely on libvirt assigning (and keeping track) of dhcp leases to configure eth0 ip addresses. Let's make sure we persist this into os-net-config so that we do not accidentally lose this config between reboots.
cjeanner
reviewed
Apr 3, 2024
rebtoor
added a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 3, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
reviewed
Apr 3, 2024
rebtoor
added a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 4, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
added a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 8, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
added a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 8, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
cjeanner
pushed a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 8, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
cjeanner
pushed a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 9, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
added a commit
to rebtoor/ci-framework
that referenced
this pull request
Apr 9, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 10, 2024
This patch allow the mapping of the `nic1` to the mac address of the default interface in compute node and is required due to [1] [1] openstack-k8s-operators/architecture#157 Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
|
/lgtm |
rebtoor
approved these changes
Apr 11, 2024
rabi
added a commit
to rabi/architecture
that referenced
this pull request
Apr 15, 2024
This reverts openstack-k8s-operators#157 Using dhcp for nic1 breaks the dns configuration by updating resolv.conf used by edpm. Reverting to fix current issues and if there is a requirement to use dhcp for nic1 it could be reworked. Signed-off-by: rabi <ramishra@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to rely on libvirt assigning (and keeping track) of dhcp leases to configure eth0 ip addresses.
Let's make sure we persist this into os-net-config so that we do not accidentally lose this config between reboots.