Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceph: build master with charmcraft3 #55

Closed
wants to merge 1 commit into from

Conversation

sabaini
Copy link
Contributor

@sabaini sabaini commented Jun 17, 2024

Add separate recipes for jammy-caracal

Add separate recipes for jammy-caracal
Copy link

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i didn't see an entry for ceph-osd charm, is it intentional ??

@sabaini
Copy link
Contributor Author

sabaini commented Jun 18, 2024

LGTM but i didn't see an entry for ceph-osd charm, is it intentional ??

There is an entry for ceph-osd, it should get its branch config from the default so no change required there.

Copy link

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!

@sabaini
Copy link
Contributor Author

sabaini commented Jun 21, 2024

Closing, need to change branch naming

@sabaini sabaini closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants