Remove duplicate prefix #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you, now we can connect to the HA of the future |
|
🎉 This PR is included in version 1.17.221 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks for addressing this so quickly! Can confirm it working with BK7231N devices, too. |
|
Just finished updating all of my devices and the error message is gone! FYI: With two devices I had to manually initiate a Home Assistant discovery even after the firmware update, but after that HA stopped complaining about those ones, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge removes the CFG_GetShortDeviceName prefix to entityName to address #895. PWM entities just have "Light" as the name. The entity_id remains unchanged. Further customization of name/icon can be done in HomeAssistant.
This has been tested on 7231T and W600 switches. I don't have other devices.
It seems that just pushing HomeAssistant discovery is not sufficient to resolve the warning, a restart at Homeassistant end might be necessary.