Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Bump fedora-coreos-config #1658

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 28, 2024

This is basically #1644 but with a commit added. Doing it this way instead of pushing to that PR directly because the bot will just nuke my changes if new commits land in f-c-c.

Adam Piasecki (1):
      denylist: add multipath.partition

Dusty Mabe (7):
      tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
      Move to Fedora Linux 41
      denylist: drop kdump.crash.nfs and ext.config.boot.bootupd-validate
      overrides: drop graduated grub2-2.12-10.fc41 override
      07fix-selinux-labels: fix service ordering
      tests/kola: fix potential unbound variable error
      ci: use OSbuild to build metal/metal4k in one shot

HuijingHei (5):
      test: extend bootupd test to include testing adoption and updates
      denylist: deny `ext.config.boot.bootupd-validate` until we rollout F41
      tests/kola: remove dtb exceptions in upgrade test SELinux checks
      tests/upgrade: drop the rollback deployment on aarch64
      tests/bootupd-validate: skip checking BIOS on older bootupd

Jonathan Lebon (17):
      workflows/add-overrides: install python3-dnf
      Inherit from fedora-bootc's tier-x on Fedora 42+
      manifests: conditionalize duplicate manifests
      manifests: split system-configuration.yaml
      manifests: split networking-tools.yaml
      manifests: split user-experience.yaml
      manifests: hoist up bootable-rpm-ostree.yaml include
      manifests: move veritysetup request to ignition-and-ostree.yaml
      manifests: move bootc to bootable-rpm-ostree.yaml
      manifests: conditionalize bootable-rpm-ostree.yaml
      manifests: just disable systemd-firstboot, don't nuke
      manifests: split ignition-and-ostree.yaml
      manifests: split tier-x dupes into separate manifest
      workflows: add `bump-fedora-bootc` workflow
      manifests/tier-x: use readonly in repo config only
      workflows/remove-graduated-overrides: clone with submodule
      manifests/fedora-coreos: move from `rojig` to `metadata`

Joseph Marrero Corchado (1):
      manifest: Add bootc

Michael Armijo (1):
      denylist: remove fcos.internet and podman.workflow

Nikita Dubrovskii (3):
      dnf5: use 'setopt' to enable 'updates-testing' repo
      dnf5 builddep: drop '--spec' as it no longer exists
      coreos-secex-ignition-prepare: remount /usr rw if needed

Adam Piasecki (1):
      denylist: add multipath.partition

Dusty Mabe (7):
      tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
      Move to Fedora Linux 41
      denylist: drop kdump.crash.nfs and ext.config.boot.bootupd-validate
      overrides: drop graduated grub2-2.12-10.fc41 override
      07fix-selinux-labels: fix service ordering
      tests/kola: fix potential unbound variable error
      ci: use OSbuild to build metal/metal4k in one shot

HuijingHei (5):
      test: extend bootupd test to include testing adoption and updates
      denylist: deny `ext.config.boot.bootupd-validate` until we rollout F41
      tests/kola: remove dtb exceptions in upgrade test SELinux checks
      tests/upgrade: drop the rollback deployment on aarch64
      tests/bootupd-validate: skip checking BIOS on older bootupd

Jonathan Lebon (17):
      workflows/add-overrides: install python3-dnf
      Inherit from fedora-bootc's tier-x on Fedora 42+
      manifests: conditionalize duplicate manifests
      manifests: split system-configuration.yaml
      manifests: split networking-tools.yaml
      manifests: split user-experience.yaml
      manifests: hoist up bootable-rpm-ostree.yaml include
      manifests: move veritysetup request to ignition-and-ostree.yaml
      manifests: move bootc to bootable-rpm-ostree.yaml
      manifests: conditionalize bootable-rpm-ostree.yaml
      manifests: just disable systemd-firstboot, don't nuke
      manifests: split ignition-and-ostree.yaml
      manifests: split tier-x dupes into separate manifest
      workflows: add `bump-fedora-bootc` workflow
      manifests/tier-x: use readonly in repo config only
      workflows/remove-graduated-overrides: clone with submodule
      manifests/fedora-coreos: move from `rojig` to `metadata`

Joseph Marrero Corchado (1):
      manifest: Add bootc

Michael Armijo (1):
      denylist: remove fcos.internet and podman.workflow

Nikita Dubrovskii (3):
      dnf5: use 'setopt' to enable 'updates-testing' repo
      dnf5 builddep: drop '--spec' as it no longer exists
      coreos-secex-ignition-prepare: remount /usr rw if needed
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

This is basically #1644 but with a commit added. Doing it this way instead of pushing to that PR directly because the bot will just nuke my changes if new commits land in f-c-c.

Adam Piasecki (1):
     denylist: add multipath.partition

Dusty Mabe (7):
     tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
     Move to Fedora Linux 41
     denylist: drop kdump.crash.nfs and ext.config.boot.bootupd-validate
     overrides: drop graduated grub2-2.12-10.fc41 override
     07fix-selinux-labels: fix service ordering
     tests/kola: fix potential unbound variable error
     ci: use OSbuild to build metal/metal4k in one shot

HuijingHei (5):
     test: extend bootupd test to include testing adoption and updates
     denylist: deny `ext.config.boot.bootupd-validate` until we rollout F41
     tests/kola: remove dtb exceptions in upgrade test SELinux checks
     tests/upgrade: drop the rollback deployment on aarch64
     tests/bootupd-validate: skip checking BIOS on older bootupd

Jonathan Lebon (17):
     workflows/add-overrides: install python3-dnf
     Inherit from fedora-bootc's tier-x on Fedora 42+
     manifests: conditionalize duplicate manifests
     manifests: split system-configuration.yaml
     manifests: split networking-tools.yaml
     manifests: split user-experience.yaml
     manifests: hoist up bootable-rpm-ostree.yaml include
     manifests: move veritysetup request to ignition-and-ostree.yaml
     manifests: move bootc to bootable-rpm-ostree.yaml
     manifests: conditionalize bootable-rpm-ostree.yaml
     manifests: just disable systemd-firstboot, don't nuke
     manifests: split ignition-and-ostree.yaml
     manifests: split tier-x dupes into separate manifest
     workflows: add `bump-fedora-bootc` workflow
     manifests/tier-x: use readonly in repo config only
     workflows/remove-graduated-overrides: clone with submodule
     manifests/fedora-coreos: move from `rojig` to `metadata`

Joseph Marrero Corchado (1):
     manifest: Add bootc

Michael Armijo (1):
     denylist: remove fcos.internet and podman.workflow

Nikita Dubrovskii (3):
     dnf5: use 'setopt' to enable 'updates-testing' repo
     dnf5 builddep: drop '--spec' as it no longer exists
     coreos-secex-ignition-prepare: remount /usr rw if needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@jlebon
Copy link
Member Author

jlebon commented Nov 29, 2024

I had to add a conditional here to make this conditional on c9s/el9.6. Once we shed 9.4 from this repo, we can drop the conditional stuff and the inherit_tier_x variable.

Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bdb5b81 and 2 for PR HEAD 2558d82 in total

Inherit from FCOS inheriting from tier-x starting from c9s and el9.6+.

The only major delta here for RHCOS is that FCOS and tier-x turn off
weak deps, but RHCOS historically has enabled them. Would be nice to
also turn them off in RHCOS as well but let's do that move separately
from this one since it additionally requires careful analysis e.g. of
what packages get dropped.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

New changes are detected. LGTM label has been removed.

@jlebon
Copy link
Member Author

jlebon commented Nov 29, 2024

/retest

1 similar comment
@c4rt0
Copy link
Contributor

c4rt0 commented Nov 30, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Nov 30, 2024

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scos-9-build-test-qemu a8f9083 link true /test scos-9-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member Author

jlebon commented Dec 2, 2024

Failure here is legit. Digging into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants