Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-18230: Bump to go version 1.22 #7011

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

MGMT-18230: Bump to go version 1.22 #7011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.assisted-service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG RHEL_VERSION=9

FROM registry.access.redhat.com/ubi$RHEL_VERSION/go-toolset:1.21 AS golang
FROM registry.access.redhat.com/ubi$RHEL_VERSION/go-toolset:1.22.5 AS golang

ADD . /app
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.assisted-service-build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi9/go-toolset:1.21 AS golang
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.5 AS golang

RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.0
RUN go install gotest.tools/gotestsum@latest
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.assisted-service-debug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM registry.access.redhat.com/ubi9/go-toolset:1.21 AS golang
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.5 AS golang

RUN GOFLAGS=-mod=mod go install github.com/go-delve/delve/cmd/dlv@v1.21.2
RUN GOFLAGS=-mod=mod go install github.com/go-delve/delve/cmd/dlv@v1.22.1

FROM quay.io/centos/centos:stream9 AS builder

Expand Down
2 changes: 1 addition & 1 deletion ci-images/Dockerfile.base
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi9/go-toolset:1.21 AS golang
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.5 AS golang

RUN go install gotest.tools/gotestsum@latest

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/openshift/assisted-service

go 1.21
go 1.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when updating the go version you should also update the linter - you may have issues if the linter is not aligned
https://github.com/paul-maidment/assisted-service/blob/MGMT-18230/ci-images/Dockerfile.lint#L3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I missed this one, thanks for the pointer.


require (
github.com/IBM/netaddr v1.5.0
Expand Down