Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use $OPENSHIFT_INSTALLER path #1647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

honza
Copy link
Member

@honza honza commented Apr 2, 2024

The ocp directory doesn't always have the binary present. For example, the cleanup commands will fail when openshift-installer is built from git. The var is populate in common.sh and the same pattern is used in utils.sh when creating the cluster.

The ocp directory doesn't always have the binary present.  For example,
the cleanup commands will fail when openshift-installer is built from
git.
@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@honza
Copy link
Member Author

honza commented Jul 30, 2024

/retest

@cybertron
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@honza
Copy link
Member Author

honza commented Aug 16, 2024

/retest-required

@elfosardo
Copy link
Member

/override ci/prow/e2e-metal-ipi-serial-ipv4
unrelated known issue

Copy link

openshift-ci bot commented Aug 21, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-serial-ipv4

In response to this:

/override ci/prow/e2e-metal-ipi-serial-ipv4
unrelated known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Member

/override ci/prow/e2e-metal-ipi-bm
unrelated issue

Copy link

openshift-ci bot commented Aug 21, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-bm

In response to this:

/override ci/prow/e2e-metal-ipi-bm
unrelated issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@honza
Copy link
Member Author

honza commented Sep 4, 2024

/retest-required

Copy link

openshift-ci bot commented Sep 4, 2024

@honza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 0a6b851 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants