-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: use $OPENSHIFT_INSTALLER path #1647
base: master
Are you sure you want to change the base?
Conversation
The ocp directory doesn't always have the binary present. For example, the cleanup commands will fail when openshift-installer is built from git.
/retest |
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/override ci/prow/e2e-metal-ipi-serial-ipv4 |
@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-serial-ipv4 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-metal-ipi-bm |
@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-bm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
@honza: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The ocp directory doesn't always have the binary present. For example, the cleanup commands will fail when openshift-installer is built from git. The var is populate in
common.sh
and the same pattern is used inutils.sh
when creating the cluster.