Skip to content

Commit

Permalink
fixes from code review, remove hashicorp copy
Browse files Browse the repository at this point in the history
  • Loading branch information
jiridanek authored and openshift-cherrypick-robot committed Jun 14, 2024
1 parent 804cc5f commit df7b7a7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions components/notebook-controller/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ WORKDIR /home/rhods
## Copy kf-notebook-controller-manager binary from builder stage
COPY --from=builder /workspace/notebook-controller/bin/manager /manager
COPY --from=builder /workspace/notebook-controller/third_party/license.txt third_party/license.txt
# in builder image, `go env GOPATH` outputs `/opt/app-root/src/go`
COPY --from=builder /opt/app-root/src/go/pkg/mod/github.com/hashicorp third_party/hashicorp

## Switch to a non-root user
USER rhods
Expand Down
3 changes: 0 additions & 3 deletions components/odh-notebook-controller/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ WORKDIR /home/rhods
## Copy kf-notebook-controller-manager binary from builder stage
COPY --from=builder /workspace/odh-notebook-controller/bin/manager /manager
COPY --from=builder /workspace/odh-notebook-controller/third_party/license.txt third_party/license.txt
# in builder image, `go env GOPATH` outputs `/opt/app-root/src/go`
COPY --from=builder //opt/app-root/src/go/pkg/mod/github.com/hashicorp third_party/hashicorp


## Switch to a non-root user
USER rhods
Expand Down

0 comments on commit df7b7a7

Please sign in to comment.