Fix several minor issues in RFS codebase #1161
Open
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
- Fix keyword ordering of DOC_CONFIG_PARAMETER_ARG_PREFIX - Created exception for Unexpected status code to remove duplicated error strings - Make check for hasCompatibilityModeEnabled null safe - Use isEmpty instead of size() == 0 - Remove redundant static modifier on CreationFailureType - Make AMAZON_SERVERLESS_VERSION final so it follows naming conventions - Have OperationFailed extend RuntimeException so it can be inheirited from, otherwise it would trigger 'java:S110 This class has 6 parents which is greater than 5 authorized.' Signed-off-by: Peter Nied <peternied@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
============================================
- Coverage 80.76% 80.76% -0.01%
+ Complexity 2948 2947 -1
============================================
Files 400 400
Lines 15104 15106 +2
Branches 1021 1021
============================================
+ Hits 12199 12200 +1
- Misses 2288 2289 +1
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix several minor issues in RFS codebase
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.